Open
Conversation
Bugfix mann whitney min size error
…replacing with np.nan to .at() and changed expected results for correlation
cmmorrow
reviewed
Sep 9, 2018
| else: | ||
| return Categorical(data) | ||
|
|
||
| def output_df(statistics_list): |
Owner
There was a problem hiding this comment.
The std_output() function is in analysis/base.py, which is probably a good place to put this function.
cmmorrow
reviewed
Sep 9, 2018
|
|
||
| def output_df(statistics_list): | ||
| df_list = [] | ||
| for stat_data in statistics_list: |
Owner
There was a problem hiding this comment.
I'd probably do this with a dictionary instead of a list where the key is the title such as "Overall Statistics" or "Group Statistics". I've been using the {'name', DataFrame} output in a couple of other places in the codebase so it'll be more consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added functionality to output stats. The format is a list of lists, where each list within the lists has the name of the statistic as the 0th element, and the dataframe or series as the 1st element.